| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: File truncation within PostgresNode::issues_sql_like() wrong on Windows |
| Date: | 2021-04-15 04:57:43 |
| Message-ID: | YHfHxz15+TKjWvP2@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 14, 2021 at 09:26:19PM -0400, Andrew Dunstan wrote:
> Well, let me try it on fairywren tomorrow. Since we manage this on the
> buildfarm without any use at all of Win32API::File it might not be
> necessary in TAP code either, particularly if we're not truncating the file.
Thanks. If that proves to not be necessary, +1 to remove this code.
I have been playing with this stuff, and the attached patch seems to
work properly on Windows. On top of that, I have also tested the
non-Win32 path on an MSVC box to see that it was working, but my
environment is not really noisy usually with such compatibility
issues.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| tap-sql-like-truncate-v2.patch | text/x-diff | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2021-04-15 06:18:50 | Re: Can a child process detect postmaster death when in pg_usleep? |
| Previous Message | Peter Geoghegan | 2021-04-15 04:30:29 | Re: New IndexAM API controlling index vacuum strategies |