| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Jehan-Guillaume de Rorthais <jgdr(at)dalibo(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multi-install PostgresNode fails with older postgres versions |
| Date: | 2021-04-21 05:13:07 |
| Message-ID: | YH+0Y8WmsOR5nPg4@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 20, 2021 at 01:11:59PM -0400, Andrew Dunstan wrote:
> Here's the patch for that.
Thanks.
> + # Accept standard formats, in case caller has handed us the output of a
> + # postgres command line tool
> + $arg = $1
> + if ($arg =~ m/\(?PostgreSQL\)? (\d+(?:\.\d+)*(?:devel)?)/);
Interesting. This would work even if using --with-extra-version,
which is a good thing.
> +# render the version number in the standard "joined by dots" notation if
> +# interpolated into a string
> +sub _stringify
> +{
> + my $self = shift;
> + return join('.', @$self);
> +}
This comes out a bit strangely when using a devel build as this
appends -1 as sub-version number, becoming say 14.-1. It may be
clearer to add back "devel" in this case?
Wouldn't it be better to add some perldoc to PostgresVersion.pm?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | torikoshia | 2021-04-21 06:08:48 | Re: wal stats questions |
| Previous Message | Bharath Rupireddy | 2021-04-21 04:54:16 | Re: Is it worth to optimize VACUUM/ANALYZE by combining duplicate rel instances into single rel instance? |