Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Cc: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Can we remove extra memset in BloomInitPage, GinInitPage and SpGistInitPage when we have it in PageInit?
Date: 2021-04-06 12:39:53
Message-ID: YGxWmUhuGEVolGLc@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 22, 2021 at 10:58:17AM +0530, Mahendra Singh Thalor wrote:
> Your changes look to fine me and I am also not getting any failure. I
> think we should back-patch all the branches.
>
> Patch is applying to all the branches(till v95) and there is no failure.

Er, no. This is just some duplicated code with no extra effect. I
have no objection to simplify a bit the whole on readability and
consistency grounds (will do so tomorrow), including the removal of
the commented-out memset call in gistinitpage, but this is not
something that should be backpatched.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Matthias van de Meent 2021-04-06 12:39:54 Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)
Previous Message Drouvot, Bertrand 2021-04-06 12:30:29 Re: Minimal logical decoding on standbys