Re: Refactoring HMAC in the core code

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Refactoring HMAC in the core code
Date: 2021-04-02 10:04:18
Message-ID: YGbsIqmk/9599r1y@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 15, 2021 at 08:25:27PM +0900, Michael Paquier wrote:
> Again a new rebase, giving v5:
> - Fixed the APIs to return -1 if the caller gives NULL in input, to be
> consistent with cryptohash.
> - Added a length argument to pg_hmac_final(), wiht sanity checks.

So, this patch has been around for a couple of weeks now, and I would
like to get this part done in 14 to close the loop with the parts of
the code that had better rely on what the crypto libs have. The main
advantage of this change is for SCRAM so as it does not use its own
implementation of HMAC whenever possible.

Any objections?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2021-04-02 10:47:39 Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Previous Message Michael Paquier 2021-04-02 09:59:31 Re: Fix pg_checksums progress report