| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: multi-install PostgresNode fails with older postgres versions |
| Date: | 2021-03-31 03:08:25 |
| Message-ID: | YGPnqThf4D2aMia6@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 30, 2021 at 11:06:55PM -0300, Alvaro Herrera wrote:
> On 2021-Mar-31, Michael Paquier wrote:
>> There is already TestLib::check_pg_config(). Shouldn't you leverage
>> that with PG_VERSION_NUM or equivalent?
>
> hmm, I wonder if we shouldn't take the stance that it is not TestLib's
> business to be calling any Pg binaries. So that routine should be moved
> to PostgresNode.
Hmm. I can see the intention, but I am not sure that this is
completely correct either to assume that we require a backend node
when tests just do tests with frontends in standalone, aka with
TestLib::program_*.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Isaac Morland | 2021-03-31 03:18:30 | Re: Add missing function abs (interval) |
| Previous Message | Neil Chen | 2021-03-31 03:02:00 | Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES |