| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor SSL test framework to support multiple TLS libraries |
| Date: | 2021-03-30 09:53:49 |
| Message-ID: | YGL1LVGdzfUZY0tQ@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 30, 2021 at 03:50:28PM +0900, Michael Paquier wrote:
> The test_*() ones are just wrappers for psql able to use a customized
> connection string. It seems to me that it would make sense to move
> those two into PostgresNode::psql itself and extend it to be able to
> handle custom connection strings?
Looking at this part, I think that this is a win in terms of future
changes for SSLServer.pm as it would become a facility only in charge
of managing the backend's SSL configuration. This has also the
advantage to make the error handling with psql more consistent with
the other tests.
So, attached is a patch to do this simplification. The bulk of the
changes is within the tests themselves to adapt to the merge of
$common_connstr and $connstr for the new routines of PostgresNode.pm,
and I have done things this way to ease the patch lookup. Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| ssl-tap-refactor-simplify.patch | text/x-diff | 25.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markus Wanner | 2021-03-30 09:54:31 | Re: [PATCH] add concurrent_abort callback for output plugin |
| Previous Message | Suraj Kharage | 2021-03-30 09:51:24 | extra semicolon in postgres_fdw test cases |