| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Jacob Champion <pchampion(at)vmware(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: hba.c:3160:18: warning: comparison of unsigned enum expression |
| Date: | 2021-04-07 11:57:03 |
| Message-ID: | YG2eD/tA+bBZHGm0@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 07, 2021 at 01:24:01PM +0200, Magnus Hagander wrote:
> On Wed, Apr 7, 2021 at 1:01 PM Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> > Recently (last day or so), I get this warning from gcc 10.2:
Same compiler version here, but I did not get warned. Are you using
any particular flag?
> But that also highlights -- shouldn't that function then also be made
> to use hba_authname(), and the assert moved into the function? That
> seems like the cleanest way?
Good idea, that's much cleaner this way. Do you like the attached?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| gcc-hba-warning.patch | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2021-04-07 12:01:42 | Re: hba.c:3160:18: warning: comparison of unsigned enum expression |
| Previous Message | Heikki Linnakangas | 2021-04-07 11:56:42 | Re: Yet another fast GiST build |