Re: pgsql: Add per-index stats information in verbose logs of autovacuum

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add per-index stats information in verbose logs of autovacuum
Date: 2021-03-24 00:38:47
Message-ID: YFqKF5IJy2yJiDuN@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Mar 22, 2021 at 11:34:47PM -0700, Peter Geoghegan wrote:
> I'm okay with preserving "pages:" if you prefer it that way. It's
> really just the word "remain" -- it reminds me of the old
> "pages_removed" field. That used to be a thing that we showed back
> when old-style VACUUM existed and could shrink the index -- this is of
> course no longer possible.
>
> The message should clearly convey that the first number shown is
> simply the total size of the index.

No arguments against that, makes sense. I have applied something that
changes "remain" to "in total" for clarity. Thanks!
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2021-03-24 00:41:49 Re: pgsql: Add per-index stats information in verbose logs of autovacuum
Previous Message Michael Paquier 2021-03-24 00:36:32 pgsql: Reword slightly logs generated for index stats in autovacuum