| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Log message for GSS connection is missing once connection authorization is successful. |
| Date: | 2021-03-20 11:29:47 |
| Message-ID: | YFXcq2vBTDGQVBNC@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 20, 2021 at 05:37:47PM +0900, Michael Paquier wrote:
> It seems to me that this would make the tests faster, that the test
> would not need to wait for the logging collector and that the code
> could just use slurp_file($node->logfile) to get the data it wants to
> check for a given pattern without looking at current_logfiles. I also
> think that not using truncate() on the logfile generated has the
> disadvantage to make the code fuzzy for its verification once we
> introduce patterns close to each other, as there could easily be an
> overlap. That's one problem that SQL pattern checks had to deal with
> in the past. Thoughts?
And, in terms of code, this really simplifies things. Please see the
attached that I would like to apply.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| krb5-test-simplify.patch | text/x-diff | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2021-03-20 13:21:54 | Re: simplifying foreign key/RI checks |
| Previous Message | Dilip Kumar | 2021-03-20 11:07:53 | Re: [HACKERS] Custom compression methods |