| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ярослав Пашинский <yarik97(dot)6(at)gmail(dot)com>, Postgres bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16927: Postgres can`t access WAL files |
| Date: | 2021-03-20 00:31:07 |
| Message-ID: | YFVCSwu4U9htrqJ/@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Mar 19, 2021 at 04:56:45PM -0700, Andres Freund wrote:
> - I think there needs to be a reference to the problem, otherwise we'll
> just redo this a couple years down the line
> - I'd not add the XXX, because the whole idea of durable_rename_excl
> seems wrong to me, and it might motivate people to come up with
> patches...
Fine by me to remove that :)
What about replacing the XXX comment by a small note, say:
"On Windows, using a hard link followed by an unlink() causes
concurrency issues with code paths interacting with those files, a
rename does not cause that."
If you have a better idea, which I am sure you do, please feel free to
send suggestions.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-20 00:37:17 | Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head |
| Previous Message | Andres Freund | 2021-03-20 00:17:48 | Re: BUG #16920: Can't compile PostGIS with MingW64 against PostgreSQL 14 head |