|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Jacob Champion <pchampion(at)vmware(dot)com>|
|Cc:||"magnus(at)hagander(dot)net" <magnus(at)hagander(dot)net>, "stark(at)mit(dot)edu" <stark(at)mit(dot)edu>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Subject:||Re: Proposal: Save user's original authenticated identity for logging|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Thu, Mar 18, 2021 at 05:14:24PM +0900, Michael Paquier wrote:
> Looking at 0001, I am not much a fan of relying on the position of the
> matching pattern in the log file. Instead of relying on the logging
> collector and one single file, why not just changing the generation of
> the logfile and rely on the output of stderr by restarting the server?
> That means less tests, no need to wait for the logging collector to do
> its business, and it solves your problem. Please see the idea with
> the patch attached. Thoughts?
While looking at 0003, I have noticed that the new kerberos tests
actually switch from a logic where one message pattern matches, to a
logic where multiple message patterns match, but I don't see a problem
with what I sent previously, as long as one consume once a log file
and matches all the patterns once, say like the following in
my $first_logfile = slurp_file($node->logfile);
# Verify specified log messages are logged in the log file.
while (my $expect_log_msg = shift @expect_log_msgs)
'found expected log file content');
# Rotate to a new file, for any next check.
A second solution would be a logrotate, relying on the contents of
current_logfiles to know what is the current file, with an extra wait
after $node->logrotate to check if the contents of current_logfiles
have changed. That's slower for me as this requires a small sleep to
make sure that the new log file name has changed, and I find the
restart solution simpler and more elegant. Please see the attached
based on HEAD for this logrotate idea.
Jacob, what do you think?
|Next Messagefirstname.lastname@example.org||2021-03-19 08:29:43||RE: Disable WAL logging to speed up data loading|
|Previous Messageemail@example.com||2021-03-19 08:04:05||RE: libpq debug log|