| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <tmunro(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: pgbench: Improve time logic. |
| Date: | 2021-03-10 07:08:44 |
| Message-ID: | YEhwfJnXkPYBtKSF@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Thomas,
On Wed, Mar 10, 2021 at 04:52:01AM +0000, Thomas Munro wrote:
> pgbench: Improve time logic.
>
> Instead of instr_time (struct timespec) and the INSTR_XXX macros,
> introduce pg_time_usec_t and use integer arithmetic. Don't include the
> connection time in TPS unless using -C mode, but report it separately.
The buildfarm is complaining after this commit with lapwing:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2021-03-10%2006%3A40%3A10
pgbench.c:3569:6: error: format '%ld' expects argument of type 'long
int', but argument 6 has type 'pg_time_usec_t' [-Werror=format]
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-03-10 07:10:02 | Re: pgsql: pgbench: Refactor thread portability support. |
| Previous Message | Michael Paquier | 2021-03-10 05:55:05 | pgsql: Move tablespace path re-creation from the makefiles to pg_regres |