| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Josef Šimánek <josef(dot)simanek(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improvements and additions to COPY progress reporting |
| Date: | 2021-03-08 08:23:50 |
| Message-ID: | YEXfFl/HWVwGjS/x@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 07, 2021 at 04:50:31PM +0530, Bharath Rupireddy wrote:
> Attaching remaining patches 0001 and 0003 from the v11 patch
> set(posted upthread) here to make cfbot happier.
Looking at patch 0002, the location of each progress report looks good
to me. I have some issues with some of the names chosen though, so I
would like to suggest a few changes to simplify things:
- PROGRESS_COPY_IO_TYPE_* => PROGRESS_COPY_TYPE_*
- PROGRESS_COPY_IO_TYPE => PROGRESS_COPY_TYPE
- PROGRESS_COPY_TYPE_STDIO => PROGRESS_COPY_TYPE_PIPE
- In pg_stat_progress_copy, io_type => type
It seems a bit confusing to not count insertions on foreign tables
where nothing happened. I am fine to live with that, but can I ask if
this has been thought about?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-03-08 08:30:25 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Peter Smith | 2021-03-08 07:56:32 | Re: [HACKERS] logical decoding of two-phase transactions |