Re: Disallow SSL compression?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Disallow SSL compression?
Date: 2021-03-05 12:37:23
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Mar 05, 2021 at 01:21:01PM +0100, Daniel Gustafsson wrote:
> On 5 Mar 2021, at 08:04, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> FWIW, I would vote to nuke it from all those places, reducing a bit
>> pg_stat_get_activity() while on it. Keeping it around in the system
>> catalogs may cause confusion IMHO, by making people think that it is
>> still possible to get into configurations where sslcompression could
>> be really enabled. The rest of the patch looks fine to me.
> Attached is a version which removes that as well.

Peter, Magnus, any comments about this point?

> I left the compression
> keyword in PQsslAttribute on purpose, not really for backwards compatibility
> (PQsslAttributeNames takes care of that) but rather since it's a more generic
> connection-info function.

Makes sense.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Laurenz Albe 2021-03-05 12:38:32 Re: Confusing behavior of psql's \e
Previous Message Daniel Gustafsson 2021-03-05 12:21:01 Re: Disallow SSL compression?