Add --tablespace option to reindexdb

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Add --tablespace option to reindexdb
Date: 2021-02-26 06:49:48
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

Since c5b2860, it is possible to specify a tablespace for a REINDEX,
but the equivalent option has not been added to reindexdb. Attached
is a patch to take care of that.

This includes documentation and tests.

While on it, I have added tests for toast tables and indexes with a
tablespace move during a REINDEX. Those operations fail, but it is
not possible to get that into the main regression test suite because
the error messages include the relation names so that's unstable.
Well, it would be possible to do that for the non-concurrent case
using a TRY/CATCH block in a custom function but that would not work
with CONCURRENTLY. Anyway, I would rather group the whole set of
tests together, and using the --tablespace option introduced here
within a TAP test does the job.

This is added to the next commit fest.


Attachment Content-Type Size
0001-Add-tablespace-option-to-reindexdb.patch text/x-diff 15.5 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-02-26 06:50:35 Re: Parallel INSERT (INTO ... SELECT ...)
Previous Message Michael J. Baars 2021-02-26 06:41:15 Re: Postgresql network transmission overhead