| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use pgstat_progress_update_multi_param instead of single param update |
| Date: | 2021-02-22 05:22:46 |
| Message-ID: | YDM/pmgfCX03frt3@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 21, 2021 at 04:43:23PM +0530, Bharath Rupireddy wrote:
> While we are at it, I wanted to use a single line statement instead of
> if else, just like we do it in do_analyze_rel as below.
>
> pgstat_progress_update_param(PROGRESS_ANALYZE_PHASE,
> inh ?
> PROGRESS_ANALYZE_PHASE_ACQUIRE_SAMPLE_ROWS_INH :
> PROGRESS_ANALYZE_PHASE_ACQUIRE_SAMPLE_ROWS);
>
> We can ignore it if it doesn't seem a good way.
What's always annoying with such things is that they create conflicts
with back-branches. So I have removed it, and applied the rest.
Thanks!
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-02-22 05:34:22 | Re: pg_collation_actual_version() ERROR: cache lookup failed for collation 123 |
| Previous Message | Justin Pryzby | 2021-02-22 05:05:26 | Re: [PATCH]: Allow errors in parameter values to be reported during the BIND phase itself.. |