Re: pgsql: Extend the abilities of libpq's target_session_attrs parameter.

On Wed, Mar 03, 2021 at 01:17:57AM +0000, Tom Lane wrote:
> Extend the abilities of libpq's target_session_attrs parameter.
>
> In addition to the existing options of "any" and "read-write", we
> now support "read-only", "primary", "standby", and "prefer-standby".
> "read-write" retains its previous meaning of "transactions are
> read-write by default", and "read-only" inverts that. The other
> three modes test specifically for hot-standby status, which is not
> quite the same thing. (Setting default_transaction_read_only on
> a primary server renders it read-only to this logic, but not a
> standby.)

pgperlcritic is complaining after this commit:
./src/test/recovery/t/001_stream_rep.pl: Variable declared in
conditional statement at line 88, column 2. Declare variables outside
of the condition. ([Variables::ProhibitConditionalDeclarations]
Severity: 5)

perlcritic is picky on this one, but you could just separate that
stuff into two lines like in the attached.
--
Michael