| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com> |
| Subject: | Re: Generating code for query jumbling through gen_node_support.pl |
| Date: | 2023-01-21 03:35:52 |
| Message-ID: | Y8tdmPlzFyNcrPR3@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 20, 2023 at 11:56:00AM +0100, Peter Eisentraut wrote:
> In your 0001 patch, most of the comment reformattings for location fields
> are no longer needed, so you should undo those.
>
> The 0002 patch looks good.
Okay, I have gone through these two again and applied what I had.
0001 has been cleaned up of the extra comment moves for the
locations. Now, I have kept a few changes for some of the nodes to
have some consistency with the other fields, in the case where most of
the fields at the end of the structures have to be marked with new
node attributes. This made the style of the header a bit more
elegant, IMV.
> I'll read the 0003 again more carefully. I haven't studied the new 0004
> yet.
Thanks, again. Rebased version attached.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0003-Support-for-automated-query-jumble-with-all-Nodes.patch | text/x-diff | 67.7 KB |
| v5-0004-Add-GUC-utility_query_id.patch | text/x-diff | 11.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-01-21 03:54:56 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |
| Previous Message | Tom Lane | 2023-01-21 03:27:07 | Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc? |