| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jelte Fennema <postgres(at)jeltef(dot)nl>, Peter Geoghegan <pg(at)bowt(dot)ie>, Magnus Hagander <magnus(at)hagander(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Jesse Zhang <sbjesse(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: run pgindent on a regular basis / scripted manner |
| Date: | 2023-01-23 21:11:50 |
| Message-ID: | Y874Fh0q4mkk1s22@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 23, 2023 at 09:31:36AM -0800, Andres Freund wrote:
> As long as we need typedefs.list, I think it'd be good for such a target to
> add new typedefs found in the local build to typedefs.list (but *not* remove
> old ones, due to platform dependent code). But that's a separate enough
> topic...
One issue on requiring patches to have run pgindent previously is
actually the typedef list. If someone adds a typedef in a commit, they
will see different pgident output in the committed files, and perhaps
others, and the new typedefs might only appear after the commit, causing
later commits to not match.
--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com
Embrace your flaws. They make you human, rather than perfect,
which you will never be.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2023-01-23 21:20:45 | Re: Non-decimal integer literals |
| Previous Message | Pavel Luzanov | 2023-01-23 21:07:58 | Re: v16 GRANT role TO role needs a multi-option setting capability |