| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | vignesh21(at)gmail(dot)com, mths(dot)dev(at)pm(dot)me, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: mprove tab completion for ALTER EXTENSION ADD/DROP |
| Date: | 2023-01-11 06:49:44 |
| Message-ID: | Y75cCLswLiFULAy1@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 11, 2023 at 12:10:33PM +0900, Kyotaro Horiguchi wrote:
> It suggests the *kinds* of objects that are part of the extension, but
> lists the objects of that kind regardless of dependency. I read
> Michael suggested (and I agree) to restrict the objects (not kinds) to
> actually be a part of the extension. (And not for object kinds.)
Yeah, that's what I meant. Now, if Vignesh does not want to extend
that, that's fine for me as well at the end on second thought, as this
involves much more code for each DROP path depending on the object
type involved.
Adding the object names after DROP/ADD is useful on its own, and we
already have some completion once the object type is specified, so
simpler is perhaps just better here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Elena Indrupskaya | 2023-01-11 07:02:02 | Re: SQL/JSON revisited |
| Previous Message | Michael Paquier | 2023-01-11 06:40:57 | Re: Avoiding "wrong tuple length" errors at the end of VACUUM on pg_database update (Backpatch of 947789f to v12 and v13) |