| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Strengthen pg_waldump's --save-fullpage tests |
| Date: | 2023-01-11 01:02:17 |
| Message-ID: | Y74Kmd4vGQuHeZTF@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 10, 2023 at 05:25:44PM +0100, Drouvot, Bertrand wrote:
> I like the idea of comparing the full page (and not just the LSN) but
> I'm not sure that adding the pageinspect dependency is a good thing.
>
> What about extracting the block directly from the relation file and
> comparing it with the one extracted from the WAL? (We'd need to skip the
> first 8 bytes to skip the LSN though).
Byte-by-byte counting for the page hole? The page checksum would
matter as well, FWIW, as it is not set in WAL and a FPW logged in WAL
means that the page got modified. It means that it could have been
flushed, updating its pd_lsn and its pd_checksum on the way.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-01-11 01:08:36 | delay starting WAL receiver |
| Previous Message | Tom Lane | 2023-01-11 00:56:28 | Re: [PATCH] support tab-completion for single quote input with equal sign |