Re: [PATCH] Add native windows on arm64 support

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Niyas Sait <niyas(dot)sait(at)linaro(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Add native windows on arm64 support
Date: 2022-12-12 23:56:33
Message-ID: Y5e/
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Dec 12, 2022 at 01:38:37PM +0000, Niyas Sait wrote:
> On 05/12/2022 18:14, Andres Freund wrote:
> I think the old build system specific part is really minimal in the patch. I
> can strip out those if that's preferred.

Removing all the changes from src/tools/msvc/ is an approach that
works for me.

>> Why does this need to be hardcoded? The compiler probe should just work for
>> msvc.
> There are couple of minor issues in the code probe with MSVC such as
> arm_acle.h needs to be removed and requires an explicit import of intrin.h.
> But even with those fixes, USE_ARMV8_CRC32C would be set and no runtime CRC
> extension check will be performed. Since CRC extension is optional in ARMv8,
> It would be better to use the CRC variant with runtime check. So I end up
> following the x64 variant and hardcoded the flags in case of ARM64 and MSVC.

Hm.. Andres, do you have access to Windows hosts with ARM64
underneath to validate any of that? No way to blame Cirrus for not
having this option, they already do a lot :)

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Joseph Koshakow 2022-12-13 00:11:16 Re: Date-Time dangling unit fix
Previous Message Jeff Davis 2022-12-12 23:47:16 Re: New strategies for freezing, advancing relfrozenxid early