| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Ted Yu <yuzhihong(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Getting rid of SQLValueFunction |
| Date: | 2022-11-20 23:12:07 |
| Message-ID: | Y3q0R6e9zOt6Er4X@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 20, 2022 at 08:21:10AM -0800, Ted Yu wrote:
> For get_func_sql_syntax(), the code for cases
> of F_CURRENT_TIME, F_CURRENT_TIMESTAMP, F_LOCALTIME and F_LOCALTIMESTAMP is
> mostly the same.
> Maybe we can introduce a helper so that code duplication is reduced.
It would. Thanks for the suggestion.
Do you like something like the patch 0002 attached? This reduces a
bit the overall size of the patch. Both ought to be merged in the
same commit, still it is easier to see the simplification created.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Replace-SQLValueFunction-by-direct-function-calls.patch | text/x-diff | 38.0 KB |
| v5-0002-Simplify-back-parsing-of-SQL-callable-timestamp-f.patch | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-11-20 23:13:16 | Re: Add LZ4 compression in pg_dump |
| Previous Message | Andres Freund | 2022-11-20 23:10:43 | Re: perform_spin_delay() vs wait events |