Re: New docs chapter on Transaction Management and related changes

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Robert Treat <rob(at)xzilla(dot)net>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Erik Rijkers <er(at)xs4all(dot)nl>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New docs chapter on Transaction Management and related changes
Date: 2022-11-18 19:31:38
Message-ID: Y3fdmraihcI2uIFs@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 10, 2022 at 08:39:29AM +0100, Laurenz Albe wrote:
> > > I don't think that is an improvement.  "Unaborted" is an un-word.  A new transaction
> > > is always "unaborted", isn't it?
> >
> > I thought about this as well when reviewing it, but I do think
> > something is needed for the case where you have a transaction which
> > has suffered an error and then you issue "rollback and chain"; if you
> > just say "a new transaction is immediately started with the same
> > transaction characteristics" it might imply to some the new
> > transaction has some kind of carry over of the previous broken
> > transaction... the use of the word unaborted makes it clear that the
> > new transaction is 100% functional.
>
> A new transaction is never aborted in my understanding. Being aborted is not a
> characteristic of a transaction, but a state.

I used "(unaborted)", which seems to be a compromise.

> > > > +    The internal transaction ID type <type>xid</type> is 32-bits wide
> > >
> > > There should be no hyphen in "32 bits wide", just as in "3 years old".
> >
> > Minor aside, we should clean up glossary.sgml as well.
>
> Right, it has this:
>
> The numerical, unique, sequentially-assigned identifier that each
> transaction receives when it first causes a database modification.
> Frequently abbreviated as <firstterm>xid</firstterm>.
> When stored on disk, xids are only 32-bits wide, so only
> approximately four billion write transaction IDs can be generated;
> to permit the system to run for longer than that,
> <firstterm>epochs</firstterm> are used, also 32 bits wide.
>
> Which reminds me that I should have suggested <firstterm> rather than
> <quote> where I complained about the use of <literal>.

I changed them to "firstterm".

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Indecision is a decision. Inaction is an action. Mark Batterson

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-11-18 19:33:26 Re: New docs chapter on Transaction Management and related changes
Previous Message Bruce Momjian 2022-11-18 19:28:41 Re: New docs chapter on Transaction Management and related changes