Re: [PATCH] Allow usage of archive .backup files as backup_label

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: Michael Banck <michael(dot)banck(at)credativ(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Allow usage of archive .backup files as backup_label
Date: 2022-11-10 04:56:45
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Oct 18, 2022 at 04:55:46AM +0200, Laurenz Albe wrote:
> I tend to agree with you. It is easy to break PostgreSQL by manipulating
> or removing "backup_label", and copying a file from the WAL archive and
> renaming it to "backup_label" sounds like a footgun of the first order.
> There is nothing that prevents you from copying the wrong file.
> Such practices should not be encouraged.
> Anybody who knows enough about PostgreSQL to be sure that what they are
> doing is correct should be smart enough to know how to edit the copied file.

A few weeks after, still the same thoughts on the matter, so please
note that I have marked that as rejected in the CF app. If somebody
wants to offer more arguments for this thread, of course please feel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2022-11-10 05:48:59 Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands
Previous Message Michael Paquier 2022-11-10 04:53:58 Re: Fix some newly modified tab-complete changes