Re: Incorrect include file order in guc-file.l

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
Cc: Julien Rouhaud <rjuju123(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect include file order in guc-file.l
Date: 2022-11-03 11:40:32
Message-ID: Y2OosGi1Xh9x/lEn@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote:
> On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
>> Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch.
>
> I've pushed this, thanks!

Thanks for the commit. I've wanted to get it done yesterday but life
took over faster than that. Before committing the change, there is
something I have noticed though: this header does not seem to be
necessary at all and it looks that there is nothing in guc-file.l that
needs it. Why did you add it in dac048f to begin with?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-11-03 11:43:04 Re: [PATCH] Add native windows on arm64 support
Previous Message David Geier 2022-11-03 11:34:41 Add explicit casts in four places to simplehash.h