Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Zhang Mingli <zmlpostgres(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [Refactor]Avoid to handle FORCE_NOT_NULL/FORCE_NULL options when COPY TO
Date: 2022-11-02 01:15:37
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Nov 01, 2022 at 05:51:42PM +0800, Richard Guo wrote:
> I'm OK with not having these assertions. I have to admit they look
> somewhat redundant here, after what ProcessCopyOptions has done.

Thanks, and done.

While on it, I have noticed some gaps with the coverage of the code,
where we did not check that FORCE_NULL & co are not allowed in some
cases. With two tests for BINARY, that made a total of 8 patterns,
applied as of 451d116.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Arne Roland 2022-11-02 01:50:38 Re: missing indexes in indexlist with partitioned tables
Previous Message David Rowley 2022-11-02 01:08:38 Re: Adding doubly linked list type which stores the number of items in the list