| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: New "single-call SRF" APIs are very confusingly named |
| Date: | 2022-10-15 02:41:08 |
| Message-ID: | Y0odxEuRbPeFVEkA@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 14, 2022 at 05:09:46PM -0400, Melanie Plageman wrote:
> To summarize, I am in support of renaming SetSingleFuncCall() ->
> InitMaterializedSRF() and SRF_SINGLE_USE_EXPECTED ->
> MAT_SRF_USE_EXPECTED_TUPLE_DESC (or just DESC) as suggested elsewhere in
> this thread. And I think we should eventually consider renaming the
> multi* function names and consider if ExprSingleResult is a good name.
As already mentioned, these have been around for years, so the impact
would be bigger. Attached is a patch for HEAD and REL_15_STABLE to
switch this stuff with new names, with what's needed for ABI
compatibility. My plan would be to keep the compatibility parts only
in 15, and drop them from HEAD.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Rename-SetSingleFuncCall-its-flags.patch | text/x-diff | 27.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-15 03:11:28 | Re: Add regular expression testing for user name mapping in the peer authentication TAP test |
| Previous Message | Tatsuo Ishii | 2022-10-15 01:40:29 | Re: make_ctags: use -I option to ignore pg_node_attr macro |