Re: Make finding openssl program a configure or meson option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Make finding openssl program a configure or meson option
Date: 2022-10-19 03:06:04
Message-ID: Y09pnCNN7Z6LGGLa@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 18, 2022 at 06:46:53PM +0200, Peter Eisentraut wrote:
> On 12.10.22 03:08, Michael Paquier wrote:
>> openssl-env allows the use of the environment variable of the same
>> name. This reminds me a bit of the recent interferences with GZIP,
>> for example.
>
> Okay, I see what you meant here now. openssl-env is the man page describing
> environment variables used by OpenSSL.

Yeah, sorry. That's what I was referring to.

> I don't see any conflicts with what is being proposed here.

Its meaning is the same in the context of the OpenSSL code. LibreSSL
has nothing of the kind.

> Added. New patch attached.

Looks fine as a whole, except for one nit.

src/test/ssl/t/001_ssltests.pl: warn 'couldn\'t run `openssl x509` to get client cert serialno';
Perhaps this warning should mentioned $ENV{OPENSSL} instead?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-10-19 03:19:28 Re: Mingw task for Cirrus CI
Previous Message Masahiko Sawada 2022-10-19 02:58:59 Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639)