Re: Missing free_var() at end of accum_sum_final()?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Joel Jacobson <joel(at)compiler(dot)org>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Missing free_var() at end of accum_sum_final()?
Date: 2023-02-20 07:38:28
Message-ID: Y/MjdPokh30ehc4n@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 19, 2023 at 11:55:38PM +0100, Joel Jacobson wrote:
> To fix, a init_var() in alloc_var() is needed when we will use the
> fixed_buf instead of allocating,
> since alloc_var() could be called in a loop for existing values,
> like in sqrt_var() for instance.
>
> Attached new version produces similar benchmark results, even with the extra init_var():

Perhaps you should register this patch to the commit of March? Here
it is:
https://commitfest.postgresql.org/42/
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-02-20 07:54:48 Re: improving user.c error messages
Previous Message Amit Langote 2023-02-20 07:35:52 Re: SQL/JSON revisited