| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Normalization of utility queries in pg_stat_statements |
| Date: | 2023-03-01 04:47:49 |
| Message-ID: | Y/7Y9U/y/keAW3qH@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 20, 2023 at 11:34:59AM +0900, Michael Paquier wrote:
> With the patches..
Attached is an updated patch set, where I have done more refactoring
work for the regression tests of pg_stat_statements, splitting
pg_stat_statments.sql into the following files:
- user_activity.sql for the role-level resets.
- wal.sql for the WAL generation tracking.
- dml.sql for insert/update/delete/merge and row counts.
- The main file is renamed to select.sql, as it now only covers SELECT
patterns.
There is no change in the code coverage or the patterns tested. And
with that, I am rather comfortable with the shape of the regression
tests moving forward.
0002 and 0003 are equivalent to the previous 0003 and 0004 in v4, that
switch pg_stat_statements to apply the normalization to utilities that
use Const nodes.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Split-more-regression-tests-of-pg_stat_statements.patch | text/x-diff | 78.0 KB |
| v5-0002-Apply-normalization-to-A_Const-and-utilities-in-p.patch | text/x-diff | 29.9 KB |
| v5-0003-Remove-normalization-of-A_Const-nodes.patch | text/x-diff | 19.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2023-03-01 04:54:50 | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Nathan Bossart | 2023-03-01 04:36:03 | Re: stopgap fix for signal handling during restore_command |