| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Force testing of query jumbling code in TAP tests |
| Date: | 2023-02-14 07:04:16 |
| Message-ID: | Y+sycL++0aObGIOO@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 13, 2023 at 09:45:12AM -0800, Andres Freund wrote:
> Shouldn't there at least be some basic verification of pg_stat_statements
> output being sane after running the test? Even if that's perhaps just actually
> printing the statements.
There is a total of 20k entries in pg_stat_statements if the max is
high enough to store everything. Only dumping the first 100
characters of each query generates at least 1MB worth of logs, which
would bloat a lot of the buildfarm in each run. So I would not do
that. One thing may be perhaps to show a count of the queries in five
categories: select, insert, delete, update and the rest?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-02-14 07:06:24 | Re: Use pg_pwritev_with_retry() instead of write() in dir_open_for_write() to avoid partial writes? |
| Previous Message | Peter Smith | 2023-02-14 06:58:09 | Re: Perform streaming logical transactions by background workers and parallel apply |