| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | bossartn(at)amazon(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pg_waldump error message fix |
| Date: | 2020-12-14 03:00:37 |
| Message-ID: | X9bVVaGinZEusb73@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 14, 2020 at 10:26:01AM +0900, Kyotaro Horiguchi wrote:
> Yeah, I had the same feeling. At least, the two LSNs in the message
> under discussion are simply redundant. So +1 to just remove the LSN at
> the caller site.
That would mean that we are ready to accept that we will never forget
to a LSN in any of the messages produced by xlogreader.c or any of the
callbacks used by pg_waldump. FWIW, I'd rather let a position in this
report than none. At least it allows users to know the area where the
problem happened.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-12-14 03:01:33 | Re: please update ps display for recovery checkpoint |
| Previous Message | k.jamison@fujitsu.com | 2020-12-14 03:00:12 | RE: [Patch] Optimize dropping of relation buffers using dlist |