Re: Change definitions of bitmap flags to bit-shifting style

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change definitions of bitmap flags to bit-shifting style
Date: 2020-12-06 06:25:06
Message-ID: X8x5QmoUxQWVEMX/@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 05, 2020 at 10:31:09PM -0300, Alvaro Herrera wrote:
> The hexadecimal representation is more natural to me than bit-shifting,
> so I would prefer to use that style too. But maybe I'm trained to it
> because of looking at t_infomask symbols constantly.

If we are going to change all that, hexa style sounds good to me too.
Would it be worth an addition to the docs, say in [1] to tell that
this is a preferred style?

[1]: https://www.postgresql.org/docs/devel/source-conventions.html?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2020-12-06 15:03:08 Re: A few new options for CHECKPOINT
Previous Message Laurenz Albe 2020-12-06 05:22:27 Re: Change definitions of bitmap flags to bit-shifting style