|From:||Michael Paquier <michael(at)paquier(dot)xyz>|
|To:||Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: Refactor MD5 implementations and switch to EVP for OpenSSL|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Tue, Nov 10, 2020 at 01:28:09PM +0900, Michael Paquier wrote:
> The CF bot has been complaining on Windows and this issue is fixed in
> the attached. A refresh of src/tools/msvc for pgcrypto was just
Now that HEAD has the necessary infrastructure to be able to plug in
easily new cryptohash routines, here is a rebased patch for MD5. The
basics are unchanged. Here is a summary:
- The duplication with MD5 implementations (pgcrypto, src/common/) is
removed, and gets only used when not building with OpenSSL.
- MD5 uses EVP when building with OpenSSL.
- Similarly to SHA2, the fallback implementation of MD5 is kept
internal to src/common/, with an internal header called md5_int.h.
The routines for init, update and final calls are similar to the SHA2
equivalents, making the changes of cryptohash.c straight-forward.
The amount of code shaved is still nice:
13 files changed, 641 insertions(+), 775 deletions(-)
|Next Messagefirstname.lastname@example.org||2020-12-04 07:05:50||RE: [Patch] Optimize dropping of relation buffers using dlist|
|Previous Message||Kyotaro Horiguchi||2020-12-04 06:37:33||Re: Is it useful to record whether plans are generic or custom?|