From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Moving other hex functions to /common |
Date: | 2021-01-11 07:45:14 |
Message-ID: | X/wCCg1Mc6uS8D5G@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jan 06, 2021 at 08:58:23AM -0500, Bruce Momjian wrote:
> Fine. Do you want to add the overflow to the patch I posted, for all
> encoding types?
Yeah. It looks that it would be good to be consistent as well for
escape case, so as it is possible to add a dstlen argument to struct
pg_encoding for the encoding and decoding routines. I would also
prefer the option to remove the argument "data" from the encode and
decode length routines for the hex routines part of src/common/, even
if it forces the creation of two small wrappers in encode.c to call
the routines of src/common/. Would you prefer if I send a patch by
myself? Please note that anything I'd send would use directly elog()
and pg_log() instead of returning status codes for the src/common/
routines, and of course not touch ECPG, as that's the approach you are
favoring.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Ian Lawrence Barwick | 2021-01-11 07:45:36 | Re: psql \df choose functions by their arguments |
Previous Message | Justin Pryzby | 2021-01-11 06:51:16 | Re: [HACKERS] Custom compression methods |