Re: Proposal: SELECT * EXCLUDE (...) command

Hi Hunaid,

Thanks for v4. I applied it to current master and went through the
cases from my earlier mails again. Everything I raised on v3 is
addressed, the minor points too. In particular, star options are
rejected outside the select list, RETURNING works (including OLD/NEW,
REPLACE and RENAME), new.* (EXCLUDE (old.x)) is rejected, and a bad
qualifier now gets the same error as in a select list. cfbot is green
as well.

One cosmetic point, take it or leave it: applyStarOptions() goes
through the lists in five quite similar loops. A small helper that
returns the matching item from one list and reports duplicates would
cut it down to finding the three items, checking the EXCLUDE
conflicts, and applying REPLACE and RENAME.

From my side the patch looks ready, so I'm marking it Ready for
Committer. The main open question is whether the behavior matches
what was accepted into the standard, e.g. for ambiguous names, and
that needs Peter's input.

Regards,
Kacper Kuras