| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Önder Kalacı' <onderkalaci(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2022-08-10 13:30:52 |
| Message-ID: | TYWPR01MB8362AF8FE96BCFCD0DA309A6ED659@TYWPR01MB8362.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tuesday, August 9, 2022 12:59 AM Önder Kalacı <onderkalaci(at)gmail(dot)com> wrote:
> Attaching v5 of the patch which reflects the review on this email, also few
> minor test improvements.
Hi,
Thank you for the updated patch.
FYI, I noticed that v5 causes cfbot failure in [1].
Could you please fix it in the next version ?
[19:44:38.420] execReplication.c: In function ‘RelationFindReplTupleByIndex’:
[19:44:38.420] execReplication.c:186:24: error: ‘eq’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
[19:44:38.420] 186 | if (!indisunique && !tuples_equal(outslot, searchslot, eq))
[19:44:38.420] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[19:44:38.420] cc1: all warnings being treated as errors
[1] - https://cirrus-ci.com/task/6544573026533376
Best Regards,
Takamichi Osumi
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-08-10 13:41:30 | something has gone wrong, but what is it? |
| Previous Message | Amit Langote | 2022-08-10 13:27:08 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |