| From: | "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, "Finnerty, Jim" <jfinnert(at)amazon(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru>, "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp> |
| Subject: | RE: Partial aggregates pushdown |
| Date: | 2023-10-27 05:32:48 |
| Message-ID: | TYTPR01MB10954B96601911FE868BF88E895DCA@TYTPR01MB10954.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Mr.Momjian.
> From: Bruce Momjian <bruce(at)momjian(dot)us>
> Sent: Friday, October 27, 2023 12:06 PM
> > Thank you for your improvement.
> > As a matter of detail, I think that the areas marked below are erroneous.
> >
> > --
> > + Pushdown causes aggregate function cals to send partial aggregate
> > ^
> > + function calls to the remote server. If the partial aggregate
> > + function doesn't doesn't exist on the remote server, it causes
> > ^^^^^^^
> > --
>
> Agreed. Do you want to fix that on your vesion? I don't have any more improvements to make.
Yes, I have fixed that in v32(Attached).
> > > What else needs to be done before committers start to review this?
> > There are no others. May I make a new version of v31 with your
> > suggested improvements for the committer's review?
>
> Yes, please. I think the updated docs will help people understand how the patch works.
Thank you. v32(Attached) is tha updated version.
Sincerely yours,
Yuuki Fujii
--
Yuuki Fujii
Information Technology R&D Center Mitsubishi Electric Corporation
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Partial-aggregates-push-down-v32.patch | application/octet-stream | 265.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2023-10-27 05:34:35 | Re: Introduce a new view for checkpointer related stats |
| Previous Message | Bharath Rupireddy | 2023-10-27 05:29:52 | Re: A recent message added to pg_upgade |