From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Introduce a new view for checkpointer related stats |
Date: | 2023-10-27 05:34:35 |
Message-ID: | CALj2ACU=-eM6kA91Ro=NTnjyyVcSTpdKMDqfacC+M50pKwhp1w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 27, 2023 at 10:32 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Oct 27, 2023 at 10:23:34AM +0530, Bharath Rupireddy wrote:
> > A possible way is to move existing pgstat_count_slru_flush in
> > SimpleLruWriteAll closer to pg_fsync and WAIT_EVENT_SLRU_SYNC in
> > SlruPhysicalWritePage, remove WAIT_EVENT_SLRU_FLUSH_SYNC completely,
> > use WAIT_EVENT_SLRU_SYNC in SlruSyncFileTag and count the flushes in
> > SlruSyncFileTag. This aggregated way is much simpler IMV.
> >
> > Another possible way is to have separate stat variables for each of
> > the SLRU flushes WAIT_EVENT_SLRU_SYNC and WAIT_EVENT_SLRU_FLUSH_SYNC
> > and expose them separately in pg_stat_slru. I don't like this
> > approach.
>
> This touches an area covered by a different patch, registered in this
> commit fest as well:
> https://www.postgresql.org/message-id/CAMm1aWb18EpT0whJrjG+-nyhNouXET6ZUw0pNYYAe+NezpvsAA@mail.gmail.com
>
> So perhaps we'd better move the discussion there. The patch posted
> there is going to need a rebase anyway once the split with
> pg_stat_checkpointer is introduced.
Yeah, I'll re-look at the SLRU stuff and the other thread next week.
> > finalized. I'm posting the pg_stat_checkpointer patch as v10-0001.
>
> Thanks. That seems OK. I don't have the wits to risk my weekend on
> buildfarm failures if any, so that will have to wait a bit.
Hm, okay :)
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2023-10-27 05:35:12 | Re: A recent message added to pg_upgade |
Previous Message | Fujii.Yuki@df.MitsubishiElectric.co.jp | 2023-10-27 05:32:48 | RE: Partial aggregates pushdown |