RE: Parallel Apply

On Friday, April 17, 2026 12:05 AM Zhijie Hou (Fujitsu) <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> On Tuesday, April 14, 2026 9:00 PM Kuroda, Hayato/黒田 隼人
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > Other comments were addressed accordingly, please see attached patch set.
>
> I started reviewing patches 0001-0004 myself, aiming to add comments where
> the design is not straightforward and to identify and fix any clearly incorrect
> behavior.
>
> Here is the updated patch set with the following improvements:
>
> * Cosmetic changes in 0001-0004
> * Additional comments in 0001-0004
> * Code simplification by merging unnecessary static functions
> * Removal of function exports left over from the POC version that are no
> longer needed
> * Got rid of XLogRecPtrIsInvalid()
> * Fixed buggy behavior in partial serialization mode, including:
> 1) The leader did not serialize the dependency on the last committed
> transaction
> 2) The parallel apply worker could not identify internal messages in
> spooled changes
> 3) An assertion failure in maybe_start_skipping_changes()
> * Added one test for serialization and restore non-streaming transactions in
> 0004.
>
> Thanks to Kuroda-San for discussing these changes internally with me.

I noticed a CFbot failure caused by a missing identification of the internal
message code, sorry for that. Here are the updated patches to fix it.

Best Regards,
Hou zj