| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, YeXiu <1518981153(at)qq(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Skipping schema changes in publication |
| Date: | 2026-04-22 10:02:56 |
| Message-ID: | TYRPR01MB1419559BE4B38E6EF24EF84BA942D2@TYRPR01MB14195.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wednesday, April 22, 2026 5:54 PM shveta malik <shveta(dot)malik(at)gmail(dot)com> wrote:
> On Mon, Apr 20, 2026 at 5:43 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Hi,
> >
> > When changing a table to UNLOGGED, tables that appear in publications
> > via EXCEPT clauses (prexcept = true) are currently allowed, but their
> > entries remain in pg_publication_rel.
> >
> > For example:
> > postgres=# create table t1(c1 int);
> > CREATE TABLE
> > postgres=# create publication pub1 for all tables except (table t1);
> > CREATE PUBLICATION postgres=# alter table t1 set unlogged; ALTER TABLE
> > postgres=# \d t1
> > Unlogged table "public.t1"
> > Column | Type | Collation | Nullable | Default
> > --------+---------+-----------+----------+---------
> > c1 | integer | | |
> > Except publications:
> > "pub1"
> >
> > Since UNLOGGED tables are not supported in publications, this leaves
> > stale catalog entries. This patch removes such entries from
> > pg_publication_rel when the table is changed to UNLOGGED, and emits a
> > NOTICE to inform the user.
> >
> > Another option considered was to throw an error when setting such
> > tables to UNLOGGED. However, allowing the operation was preferred,
> > since UNLOGGED tables do not generate WAL and are not replicated
> > anyway, so blocking the operation would be unnecessarily restrictive.
> >
> > Attached patch has the changes for the same.
> >
>
> The main concern of removal table form EXCEPT-list is that once the table is
> changed back to LOGGED, there is no internal way to add it to the EXCEPT list
> again.
>
> OTOH, raising an ERROR does not seem like a good solution either. When a
> user converts a table to UNLOGGED, they are effectively excluding it from
> publications. Therefore, throwing an error for the purpose that "table is part
> of EXCEPT, cannot convert it to UNLOGGED" does not appear appropriate,
> since both actions ultimately exclude the table from publication. I think we
> can keep the current behavior unchanged as it causes no harm.
I also personally prefer keeping the current behavior, as there is no harm in
doing so, and I'm not sure whether reporting one more ERROR would make users
happy.
Best Regards,
Hou zj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-04-22 10:33:09 | Re: [PATCH] Fix: Partitioned parent index remains invalid after child indexes are repaired |
| Previous Message | shveta malik | 2026-04-22 09:54:28 | Re: Skipping schema changes in publication |