| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Ajin Cherian' <itsajin(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: [PATCH] Preserve replication origin OIDs in pg_upgrade |
| Date: | 2026-05-07 07:47:01 |
| Message-ID: | TYRPR01MB12156B9573547DC15C6609619F53C2@TYRPR01MB12156.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Ajin,
Thanks for updating the patch. Let me share my two high-level comments.
1.
Can you clarify the policy for backward compatibility? In other words, should we
preserve subscription OIDs and migrate replication origins from PG19- instances?
Similar commits 9a17be1 and 29d0a77 did not allow migrating objects from released
versions.
2.
I found that other objects use global variables like binary_upgrade_next_xxx to
specify the next OID. Can we follow the manner even for replication origins?
Or it's not a good approach because of some reasons?
BTW, cfbot got angry with your patch.
Best regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-05-07 08:04:16 | Re: Fix bug with accessing to temporary tables of other sessions |
| Previous Message | SATYANARAYANA NARLAPURAM | 2026-05-07 07:45:54 | Re: Skip prefetch for block references that follow a FPW or WILL_INIT of the same block |