| From: | "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, "vignesh21(at)gmail(dot)com" <vignesh21(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, "shveta(dot)malik(at)gmail(dot)com" <shveta(dot)malik(at)gmail(dot)com>, "dilipbalaut(at)gmail(dot)com" <dilipbalaut(at)gmail(dot)com>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com>, "m(dot)melihmutlu(at)gmail(dot)com" <m(dot)melihmutlu(at)gmail(dot)com>, "andres(at)anarazel(dot)de" <andres(at)anarazel(dot)de>, "marcos(at)f10(dot)com(dot)br" <marcos(at)f10(dot)com(dot)br>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Time delayed LR (WAS Re: logical replication restrictions) |
| Date: | 2023-01-24 12:19:04 |
| Message-ID: | TYCPR01MB8373DC1881F382B4703F26E0EDC99@TYCPR01MB8373.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tuesday, January 24, 2023 5:52 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Jan 24, 2023 at 12:44 PM Peter Smith <smithpb2250(at)gmail(dot)com>
> wrote:
> >
> > On Tue, Jan 24, 2023 at 5:58 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> wrote:
> > >
> > > On Tue, Jan 24, 2023 at 8:15 AM Kyotaro Horiguchi
> > > <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > > >
> > > > > Attached the updated patch v19.
> > > >
> > > > + maybe_delay_apply(TransactionId xid, TimestampTz finish_ts)
> > > >
> > > > I look this spelling strange. How about maybe_apply_delay()?
> > > >
> > >
> > > +1.
> >
> > It depends on how you read it. I read it like this:
> >
> > maybe_delay_apply === means "maybe delay [the] apply"
> > (which is exactly what the function does)
> >
> > versus
> >
> > maybe_apply_delay === means "maybe [the] apply [needs a] delay"
> > (which is also correct, but it seemed a more awkward way to say it
> > IMO)
> >
>
> This matches more with GUC and all other usages of variables in the patch. So,
> I still prefer the second one.
Okay. Fixed.
Attached the patch v20 that has incorporated all comments so far.
Kindly have a look at the attached patch.
Best Regards,
Takamichi Osumi
| Attachment | Content-Type | Size |
|---|---|---|
| v20-0001-Time-delayed-logical-replication-subscriber.patch | application/octet-stream | 81.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Takamichi Osumi (Fujitsu) | 2023-01-24 12:32:03 | RE: Time delayed LR (WAS Re: logical replication restrictions) |
| Previous Message | Jelte Fennema | 2023-01-24 11:44:00 | Re: run pgindent on a regular basis / scripted manner |