| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, osumi(dot)takamichi(at)fujitsu(dot)com, vignesh21(at)gmail(dot)com, kuroda(dot)hayato(at)fujitsu(dot)com, shveta(dot)malik(at)gmail(dot)com, dilipbalaut(at)gmail(dot)com, euler(at)eulerto(dot)com, m(dot)melihmutlu(at)gmail(dot)com, andres(at)anarazel(dot)de, marcos(at)f10(dot)com(dot)br, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Date: | 2023-01-24 08:52:19 |
| Message-ID: | CAA4eK1JHy8edLMHHz8pWtxJ8HoCmB8k7LkJKZfRU6aOHHYG3eA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 24, 2023 at 12:44 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Tue, Jan 24, 2023 at 5:58 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Tue, Jan 24, 2023 at 8:15 AM Kyotaro Horiguchi
> > <horikyota(dot)ntt(at)gmail(dot)com> wrote:
> > >
> > > > Attached the updated patch v19.
> > >
> > > + maybe_delay_apply(TransactionId xid, TimestampTz finish_ts)
> > >
> > > I look this spelling strange. How about maybe_apply_delay()?
> > >
> >
> > +1.
>
> It depends on how you read it. I read it like this:
>
> maybe_delay_apply === means "maybe delay [the] apply"
> (which is exactly what the function does)
>
> versus
>
> maybe_apply_delay === means "maybe [the] apply [needs a] delay"
> (which is also correct, but it seemed a more awkward way to say it IMO)
>
This matches more with GUC and all other usages of variables in the
patch. So, I still prefer the second one.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2023-01-24 09:56:44 | Re: Schema variables - new implementation for Postgres 15 (typo) |
| Previous Message | Kyotaro Horiguchi | 2023-01-24 08:33:42 | Re: Time delayed LR (WAS Re: logical replication restrictions) |