RE: Modify the document of Logical Replication configuration settings

From: "Takamichi Osumi (Fujitsu)" <osumi(dot)takamichi(at)fujitsu(dot)com>
To: 'Michael Paquier' <michael(at)paquier(dot)xyz>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Modify the document of Logical Replication configuration settings
Date: 2023-01-19 16:06:14
Message-ID: TYCPR01MB8373A3F7267C89260C8AFF27EDC49@TYCPR01MB8373.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thursday, January 19, 2023 3:14 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Jan 18, 2023 at 02:04:16PM +0530, Bharath Rupireddy wrote:
> > [1]
> > diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index
> > 89d53f2a64..6f9509267c 100644
> > --- a/doc/src/sgml/config.sgml
> > +++ b/doc/src/sgml/config.sgml
> > @@ -4326,7 +4326,8 @@ restore_command = 'copy
> > "C:\\server\\archivedir\\%f" "%p"' # Windows
> > <para>
> > Terminate replication connections that are inactive for longer
> > than this amount of time. This is useful for
> > - the sending server to detect a standby crash or network outage.
> > + the sending server to detect a standby crash or logical replication
> > + subscriber crash or network outage.
> > If this value is specified without units, it is taken as milliseconds.
> > The default value is 60 seconds.
> > A value of zero disables the timeout mechanism.
>
> Perhaps we could do that, I am not sure whether this brings much in this
> section, though.
This might increase comprehensiveness of the doc slightly.

If we want to do this, it might be better to
add this kind of additions to other parameters such as
wal_receiver_timeout, wal_retrieve_retry_interval
and wal_receiver_status_interval, too.

BTH, thank you for having taken care of my patch, Michael-san!

Best Regards,
Takamichi Osumi

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-19 16:13:30 Re: Rethinking the implementation of ts_headline()
Previous Message Pavel Stehule 2023-01-19 15:54:43 Re: Re: Support plpgsql multi-range in conditional control