| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Amit Kapila' <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "wangw(dot)fnst(at)fujitsu(dot)com" <wangw(dot)fnst(at)fujitsu(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Optionally automatically disable logical replication subscriptions on error |
| Date: | 2022-02-25 12:48:09 |
| Message-ID: | TYCPR01MB83738F8BD091D12E8C3B2523ED3E9@TYCPR01MB8373.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, February 24, 2022 8:09 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
> On Thu, Feb 24, 2022 at 1:20 PM Masahiko Sawada
> <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > + /*
> > + * Log the error that caused DisableSubscriptionOnError to be
> called. We
> > + * do this immediately so that it won't be lost if some other internal
> > + * error occurs in the following code.
> > + */
> > + EmitErrorReport();
> > + AbortOutOfAnyTransaction();
> > + FlushErrorState();
> >
> > Do we need to hold interrupts during cleanup here?
> >
>
> I think so. We do prevent interrupts via
> HOLD_INTERRUPTS/RESUME_INTERRUPTS during cleanup.
Fixed.
Kindly have a look at v22 shared in [1].
Best Regards,
Takamichi Osumi
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2022-02-25 12:48:55 | Re: [PATCH] add relation and block-level filtering to pg_waldump |
| Previous Message | osumi.takamichi@fujitsu.com | 2022-02-25 12:45:04 | RE: Optionally automatically disable logical replication subscriptions on error |