| From: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
|---|---|
| To: | 'Greg Nancarrow' <gregn4422(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Smith, Peter" <peters(at)fast(dot)au(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: Optionally automatically disable logical replication subscriptions on error |
| Date: | 2021-11-18 07:22:15 |
| Message-ID: | TYCPR01MB837308EA9546476CFA0C53F0ED9B9@TYCPR01MB8373.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, November 18, 2021 2:08 PM Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> A minor comment:
Thanks for your comments !
> doc/src/sgml/ref/alter_subscription.sgml
> (1) disable_on_err?
>
> + <literal>disable_on_err</literal>.
>
> This doc update names the new parameter as "disable_on_err" instead of
> "disable_on_error".
> Also "disable_on_err" appears in a couple of the test case comments.
Fixed all 3 places.
At the same time, I changed one function name
from IsSubscriptionDisablingError() to IsTransientError()
so that it can express what it checks correctly.
Of course, the return value of true or false
becomes reverse by this name change, but
This would make the function more general.
Also, its comments were fixed.
This version also depends on the v23 of skip xid [1]
Best Regards,
Takamichi Osumi
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Optionally-disable-subscriptions-on-error.patch | application/octet-stream | 47.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ken Kato | 2021-11-18 07:25:30 | Re: CREATE tab completion |
| Previous Message | Noah Misch | 2021-11-18 07:05:06 | Re: XLogReadRecord() error in XlogReadTwoPhaseData() |