| From: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
|---|---|
| To: | 'Masahiko Sawada' <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Subject: | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Date: | 2023-08-21 13:04:06 |
| Message-ID: | TYCPR01MB58706C12DE4EDEEFD62B5C09F51EA@TYCPR01MB5870.jpnprd01.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dear Sawada-san,
Thank you for reviewing! New patch set can be available in [1].
>
> 0001:
>
> Do we need regression tests to make sure that the slot's
> confirmed_flush_lsn matches the LSN of the latest shutdown_checkpoint
> record?
Added. I wondered the location of the test, but put on
test_decoding/t/002_always_persist.pl.
> 0002:
>
> + <step>
> + <title>Prepare for publisher upgrades</title>
> +
>
> Should this step be done before "8. Stop both servers" as it might
> require to disable subscriptions and to drop 'lost' replication slots?
Right, moved.
> Why is there no explanation about the slots' confirmed_flush_lsn check
> as prerequisites?
Added.
Best Regards,
Hayato Kuroda
FUJITSU LIMITED
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2023-08-21 13:04:58 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-08-21 13:02:30 | RE: [PoC] pg_upgrade: allow to upgrade publisher node |