RE: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger

From: "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: RE: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger
Date: 2022-07-15 03:21:30
Message-ID: TYCPR01MB587008E7121BBDDE98482484F58B9@TYCPR01MB5870.jpnprd01.prod.outlook.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> > I noticed that we didn't collect the ObjectAddress returned by
> > ATExec[Attach|Detach]Partition. I think collecting this information can make it
> > easier for users to get the partition OID of the attached or detached table in
> > the event trigger. So how about collecting it like the attached patch ?
>
> Added to next CF.

Sounds good. I grepped ATExecXXX() functions called in ATExecCmd(),
and I confirmed that all returned values have been collected except them.

While checking test code test about EVENT TRIGGER,
I found there were no tests related with partitions in that.
How about adding them?

Best Regards,
Hayato Kuroda
FUJITSU LIMITED

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-07-15 03:41:03 Re: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger
Previous Message houzj.fnst@fujitsu.com 2022-07-15 02:26:16 RE: Collect ObjectAddress for ATTACH DETACH PARTITION to use in event trigger